Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scale in compute_photo_and_geometry_loss #23

Open
ronamit opened this issue Aug 26, 2023 · 0 comments
Open

scale in compute_photo_and_geometry_loss #23

ronamit opened this issue Aug 26, 2023 · 0 comments

Comments

@ronamit
Copy link

ronamit commented Aug 26, 2023

Hello, thanks for publishing the code!
In the function compute_photo_and_geometry_loss, the code that handles scaling is commented out, and there is not adjustment of the camera intrinsic to the scale.
Is this an error or a desired behavior?
Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronamit