Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to improve clang-tidy runtimes #21

Merged
merged 16 commits into from
Jul 15, 2023

Conversation

reedacartwright
Copy link
Contributor

@reedacartwright reedacartwright commented Jul 13, 2023

Add a .clang-tidy-ignore and .clang-tidy-include files.

Remove and rearrange #include lines to reduce the amount of unused headers included in files.

Partially fixes #13

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage: 89.28% and project coverage change: +0.22 🎉

Comparison is base (cd2700e) 90.00% compared to head (526733b) 90.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   90.00%   90.22%   +0.22%     
==========================================
  Files          24       25       +1     
  Lines        1721     1709      -12     
  Branches      911      904       -7     
==========================================
- Hits         1549     1542       -7     
+ Misses         49       47       -2     
+ Partials      123      120       -3     
Impacted Files Coverage Δ
src/include/coati/align_pair.hpp 100.00% <ø> (ø)
src/include/coati/dna_syms.hpp 2.73% <ø> (ø)
src/include/coati/semiring.hpp 100.00% <ø> (ø)
src/include/coati/structs.hpp 75.00% <ø> (+2.27%) ⬆️
src/lib/align_fst.cc 100.00% <ø> (ø)
src/lib/align_marginal.cc 85.83% <ø> (ø)
src/lib/fasta.cc 90.24% <ø> (ø)
src/lib/json.cc 92.50% <ø> (ø)
src/lib/mutation_fst.cc 98.16% <ø> (ø)
src/lib/phylip.cc 94.64% <ø> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@reedacartwright reedacartwright merged commit 3275996 into CartwrightLab:master Jul 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long runtime for ninja clang-tidy
2 participants