OSM buildings are very shiny

[jjspace]

simplescreenrecorder-2024-12-05_11.10.32.mp4

According to a discussion on Slack the OSM buildings have always been shiny it just wasn't very obvious in the past. Something in the 1.124 release however has made if very obvious and created the sort of "star" pattern you can see in the video above. The video also shows switching back to 1.123 to show that the pattern was there before just much much more subtle so it didn't look like a portal to another dimension.

I'm assuming this is a result of some of the lighting/environment map changes that we've added to help general visual quality. I haven't tried to do a git bisect or anything yet to get to the root commit that caused this change.

I'm hoping this maay be an easy change in how we create the tileset in the OSM buildings helper but even if we can we should probably look into fixing it. This will be very obvious for anyone using the OSM buildings and moving the camera around (like in our beginner flight tracker tutorial)

[dkbraig]

While testing OSM building updates, I noticed some visual weirdness in the OSM building materials I am not sure if this is related or a separate issue

[ggetz]

@dkbraig It also looks like the cubemap for image-base lighting is rotated on it side for that dataset. The green color should be coming from beneath the building, not to the side like in this image:

[ggetz]

For the above, #12310 may be the cause.