Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMD key to KeyboardEventModifier #12369

Open
KevinKibler-Lovelace opened this issue Dec 10, 2024 · 2 comments
Open

Add support for CMD key to KeyboardEventModifier #12369

KevinKibler-Lovelace opened this issue Dec 10, 2024 · 2 comments

Comments

@KevinKibler-Lovelace
Copy link

KevinKibler-Lovelace commented Dec 10, 2024

Feature

On MacOS, the CMD key is roughly (but not exactly) analogous to the CTRL key on Windows. Many keyboard shortcuts that use CTRL + on Windows use CMD + on MacOS.

Add META to the KeyboardEventModifier object to better support Cesium on MacOS.

@KevinKibler-Lovelace
Copy link
Author

@jjspace
Copy link
Contributor

jjspace commented Dec 10, 2024

Just as a note, we rely on browser support for keyboard modifiers. To support Command we will need to add KeyboardEventModifier.META not CMD because browsers consider Command as the Meta key KeyboardEvent.metaKey

@KevinKibler-Lovelace KevinKibler-Lovelace changed the title Add CMD key to KeyboardEventModifier Add support for CMD key to KeyboardEventModifier Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants