Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eye Dome Lighting broken in VR mode #8704

Open
lilleyse opened this issue Mar 27, 2020 · 5 comments
Open

Eye Dome Lighting broken in VR mode #8704

lilleyse opened this issue Mar 27, 2020 · 5 comments

Comments

@lilleyse
Copy link
Contributor

Sandcastle (make sure to click the VR button)

bad2

@emackey
Copy link
Contributor

emackey commented Apr 16, 2020

Reminder: Cesium's "VR" mode pre-dates actual WebVR, which itself has been folded into WebXR. Rather than fixing bugs in Cesium VR, consider replacing it with a more modern WebXR integration.

@mramato
Copy link
Contributor

mramato commented Apr 16, 2020

@emackey PRs welcome 😄

Full support for WebXR is definitely on our long term roadmap, but with so many exciting things happening in the Cesium world, it will most likely be some time before we get to it.

@emackey
Copy link
Contributor

emackey commented Apr 16, 2020

Yeah, I might have a tough time justifying to AGI, but it would be a ton of fun, and I do have hardware to properly test it.

Actually my biggest concern about it is that Cesium likes to hand-craft its model and projection matrices for the camera. In WebXR (and WebVR before it), the model and projection matrices for left and right eyes are handed over by the browser API to the application, using a world space that corresponds to the user's actual environment (their living room or wherever they stand or sit).

So basically we need to short-circuit Cesium's camera logic for figuring these matrices out, and inject the browser-supplied matrices instead, dealing with any downstream dependencies of those appropriately.

After that we would need some UI for allowing the user to arbitrarily scale scene space relative to user-world-space, and change locations etc. But just getting an in-place WebXR immersive camera in place would make a great first PR on this front.

I don't think this is the kind of project I could embark on alone. I would want a collaborator with some understanding of Cesium camera/view internals.

@mramato
Copy link
Contributor

mramato commented Apr 16, 2020

While it's probably out of date, we do have an issue for this: #3422 Please feel free to provide any and all thoughts there so that when we go to do it we have the research all in one place. Thanks!

@Winley113
Copy link

How can I get the full source code of this API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants