Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing firefox in browser tests #7307

Open
ensi321 opened this issue Dec 16, 2024 · 0 comments · May be fixed by #7318
Open

Fix installing firefox in browser tests #7307

ensi321 opened this issue Dec 16, 2024 · 0 comments · May be fixed by #7318
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@ensi321
Copy link
Contributor

ensi321 commented Dec 16, 2024

Describe the bug

Current browser tests CI installs Firefox by running

run: npx @puppeteer/browsers install firefox@latest --path /tmp

However it attempts to download a browser by pointing to an url that no longer exists:

Run npx @puppeteer/browsers install firefox@latest --path /tmp
@puppeteer/browsers install <browser>

Download and install the specified browser. If successful, the command outputs the actual browser buildId that was installed and the absolute path to the browser executable (format: <browser>@<buildID> <path>).
...
Error: Download failed: server returned code 404. URL: https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-135.0a1.en-US.linux-x86_64.tar.bz2
    at /home/runner/actions-runner/_work/lodestar/lodestar/node_modules/@puppeteer/browsers/lib/cjs/httpUtil.js:95:31
    at ClientRequest.requestCallback (/home/runner/actions-runner/_work/lodestar/lodestar/node_modules/@puppeteer/browsers/lib/cjs/httpUtil.js:72:13)
    at Object.onceWrapper (node:events:635:26)
    at ClientRequest.emit (node:events:520:28)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:700:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
    at TLSSocket.socketOnData (node:_http_client:542:22)
    at TLSSocket.emit (node:events:520:28)
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
Error: Process completed with exit code 1.

Hence failing the entire browser tests

Expected behavior

Successfully pass the browser tests

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.24.0

@ensi321 ensi321 added the meta-bug Issues that identify a bug and require a fix. label Dec 16, 2024
@philknows philknows added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Dec 19, 2024
@nflaig nflaig linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants