🚧 use anyhow::Result instead of io::Result in cli

cli/src/command.rs

@@ -20,7 +20,7 @@ mod xattr;
 use crate::cli::{CipherAlgorithmArgs, Cli, Commands, PasswordArgs};
 use std::{fs, io};
 
-pub fn entry(cli: Cli) -> io::Result<()> {
+pub fn entry(cli: Cli) -> anyhow::Result<()> {
     match cli.commands {
         Commands::Create(cmd) => cmd.execute(),
         Commands::Append(cmd) => cmd.execute(),
@@ -62,5 +62,5 @@ fn check_password(password: &Option<String>, cipher_args: &CipherAlgorithmArgs)
 }
 
 trait Command {
-    fn execute(self) -> io::Result<()>;
+    fn execute(self) -> anyhow::Result<()>;
 }

cli/src/command/acl.rs

@@ -33,7 +33,7 @@ pub(crate) struct AclCommand {
 
 impl Command for AclCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         match self.command {
             XattrCommands::Get(cmd) => cmd.execute(),
             XattrCommands::Set(cmd) => cmd.execute(),
@@ -61,7 +61,7 @@ pub(crate) struct GetAclCommand {
 
 impl Command for GetAclCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         archive_get_acl(self)
     }
 }
@@ -84,7 +84,7 @@ pub(crate) struct SetAclCommand {
 
 impl Command for SetAclCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         archive_set_acl(self)
     }
 }
@@ -207,7 +207,7 @@ impl FromStr for AclEntries {
     }
 }
 
-fn archive_get_acl(args: GetAclCommand) -> io::Result<()> {
+fn archive_get_acl(args: GetAclCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     if args.files.is_empty() {
         return Ok(());
@@ -245,7 +245,7 @@ fn archive_get_acl(args: GetAclCommand) -> io::Result<()> {
     Ok(())
 }
 
-fn archive_set_acl(args: SetAclCommand) -> io::Result<()> {
+fn archive_set_acl(args: SetAclCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     if args.files.is_empty() {
         return Ok(());
@@ -290,7 +290,8 @@ fn archive_set_acl(args: SetAclCommand) -> io::Result<()> {
             },
             TransformStrategyKeepSolid,
         ),
-    }
+    }?;
+    Ok(())
 }
 
 #[inline]

cli/src/command/append.rs

@@ -11,6 +11,7 @@ use crate::{
     },
     utils::{self, PathPartExt},
 };
+use anyhow::Context;
 use clap::{ArgGroup, Parser, ValueHint};
 use pna::Archive;
 use rayon::ThreadPoolBuilder;
@@ -92,20 +93,21 @@ pub(crate) struct AppendCommand {
 
 impl Command for AppendCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         append_to_archive(self)
     }
 }
 
-fn append_to_archive(args: AppendCommand) -> io::Result<()> {
+fn append_to_archive(args: AppendCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     check_password(&password, &args.cipher);
     let archive_path = args.file.archive;
     if !archive_path.exists() {
         return Err(io::Error::new(
             io::ErrorKind::NotFound,
             format!("{} is not exists", archive_path.display()),
-        ));
+        ))
+        .with_context(|| format!("{} does not exists", archive_path.display()));
     }
     let mut num = 1;
     let file = File::options().write(true).read(true).open(&archive_path)?;

cli/src/command/chmod.rs

@@ -7,6 +7,7 @@ use crate::{
     },
     utils::{GlobPatterns, PathPartExt},
 };
+use anyhow::Context;
 use bitflags::bitflags;
 use clap::{Parser, ValueHint};
 use pna::NormalEntry;
@@ -28,12 +29,12 @@ pub(crate) struct ChmodCommand {
 
 impl Command for ChmodCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         archive_chmod(self)
     }
 }
 
-fn archive_chmod(args: ChmodCommand) -> io::Result<()> {
+fn archive_chmod(args: ChmodCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     if args.files.is_empty() {
         return Ok(());
@@ -70,6 +71,7 @@ fn archive_chmod(args: ChmodCommand) -> io::Result<()> {
             TransformStrategyKeepSolid,
         ),
     }
+    .with_context(|| "While processing a chmod file")
 }
 
 #[inline]

cli/src/command/chown.rs

@@ -9,6 +9,7 @@ use crate::{
     },
     utils::{GlobPatterns, PathPartExt},
 };
+use anyhow::Context;
 use clap::{Parser, ValueHint};
 use pna::NormalEntry;
 use std::ops::Not;
@@ -30,12 +31,12 @@ pub(crate) struct ChownCommand {
 
 impl Command for ChownCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         archive_chown(self)
     }
 }
 
-fn archive_chown(args: ChownCommand) -> io::Result<()> {
+fn archive_chown(args: ChownCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     if args.files.is_empty() {
         return Ok(());
@@ -72,6 +73,7 @@ fn archive_chown(args: ChownCommand) -> io::Result<()> {
             TransformStrategyKeepSolid,
         ),
     }
+    .with_context(|| "failed to combine transforms")
 }
 
 #[inline]

cli/src/command/complete.rs

@@ -11,7 +11,7 @@ pub(crate) struct CompleteCommand {
 
 impl Command for CompleteCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         let cmd = &mut Cli::command();
         print_completions(self.shell, cmd);
         Ok(())

cli/src/command/concat.rs

@@ -3,6 +3,7 @@ use crate::command::commons::run_across_archive_mem;
 #[cfg(not(feature = "memmap"))]
 use crate::command::commons::{run_across_archive, PathArchiveProvider};
 use crate::{cli::FileArgs, command::Command, utils};
+use anyhow::Context;
 use clap::Parser;
 use pna::Archive;
 use std::{fs, io};
@@ -17,24 +18,26 @@ pub(crate) struct ConcatCommand {
 
 impl Command for ConcatCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         concat_entry(self)
     }
 }
 
-fn concat_entry(args: ConcatCommand) -> io::Result<()> {
+fn concat_entry(args: ConcatCommand) -> anyhow::Result<()> {
     if !args.overwrite && args.files.archive.exists() {
         return Err(io::Error::new(
             io::ErrorKind::AlreadyExists,
             format!("{} is already exists", args.files.archive.display()),
-        ));
+        ))
+        .with_context(|| "");
     }
     for item in &args.files.files {
         if !utils::fs::is_pna(item)? {
             return Err(io::Error::new(
                 io::ErrorKind::InvalidData,
                 format!("{} is not a pna file", item),
-            ));
+            ))
+            .with_context(|| "");
         }
     }
     let file = fs::File::create(&args.files.archive)?;

cli/src/command/create.rs

@@ -12,6 +12,7 @@ use crate::{
     },
     utils::{self, fmt::DurationDisplay},
 };
+use anyhow::Context;
 use bytesize::ByteSize;
 use clap::{ArgGroup, Parser, ValueHint};
 use pna::{Archive, SolidEntryBuilder, WriteOptions};
@@ -105,12 +106,12 @@ pub(crate) struct CreateCommand {
 
 impl Command for CreateCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         create_archive(self)
     }
 }
 
-fn create_archive(args: CreateCommand) -> io::Result<()> {
+fn create_archive(args: CreateCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password.clone())?;
     check_password(&password, &args.cipher);
     let start = Instant::now();
@@ -119,7 +120,8 @@ fn create_archive(args: CreateCommand) -> io::Result<()> {
         return Err(io::Error::new(
             io::ErrorKind::AlreadyExists,
             format!("{} is already exists", archive.display()),
-        ));
+        ))
+        .with_context(|| "");
     }
     log::info!("Create an archive: {}", archive.display());
     let mut files = args.file.files;

cli/src/command/delete.rs

@@ -9,6 +9,7 @@ use crate::{
     },
     utils::{GlobPatterns, PathPartExt},
 };
+use anyhow::Context;
 use clap::{ArgGroup, Parser, ValueHint};
 use std::{io, path::PathBuf};
 
@@ -29,12 +30,12 @@ pub(crate) struct DeleteCommand {
 
 impl Command for DeleteCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         delete_file_from_archive(self)
     }
 }
 
-fn delete_file_from_archive(args: DeleteCommand) -> io::Result<()> {
+fn delete_file_from_archive(args: DeleteCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     let globs = GlobPatterns::new(args.file.files)
         .map_err(|e| io::Error::new(io::ErrorKind::InvalidInput, e))?;
@@ -72,4 +73,5 @@ fn delete_file_from_archive(args: DeleteCommand) -> io::Result<()> {
             TransformStrategyKeepSolid,
         ),
     }
+    .with_context(|| "While deleting a file")
 }

cli/src/command/experimental.rs

@@ -1,6 +1,5 @@
 use crate::{command, command::Command};
 use clap::{Parser, Subcommand};
-use std::io;
 
 #[derive(Parser, Clone, Eq, PartialEq, Hash, Debug)]
 #[command(args_conflicts_with_subcommands = true, arg_required_else_help = true)]
@@ -11,7 +10,7 @@ pub(crate) struct ExperimentalCommand {
 
 impl Command for ExperimentalCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         match self.command {
             ExperimentalCommands::Stdio(cmd) => cmd.execute(),
             ExperimentalCommands::Delete(cmd) => cmd.execute(),

cli/src/command/extract.rs

@@ -78,11 +78,11 @@ pub(crate) struct ExtractCommand {
 
 impl Command for ExtractCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         extract_archive(self)
     }
 }
-fn extract_archive(args: ExtractCommand) -> io::Result<()> {
+fn extract_archive(args: ExtractCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     let start = Instant::now();
     log::info!("Extract archive {}", args.file.archive.display());

cli/src/command/list.rs

@@ -13,6 +13,7 @@ use crate::{
     ext::*,
     utils::GlobPatterns,
 };
+use anyhow::Context;
 use chrono::{DateTime, Local};
 use clap::{
     builder::styling::{AnsiColor, Color as Colour, Style},
@@ -76,7 +77,7 @@ pub(crate) struct ListCommand {
 
 impl Command for ListCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         list_archive(self)
     }
 }
@@ -200,7 +201,7 @@ where
     }
 }
 
-fn list_archive(args: ListCommand) -> io::Result<()> {
+fn list_archive(args: ListCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     let options = ListOptions {
         long: args.long,
@@ -219,6 +220,7 @@ fn list_archive(args: ListCommand) -> io::Result<()> {
             &args.file.files,
             options,
         )
+        .with_context(|| "")
     }
     #[cfg(feature = "memmap")]
     {
@@ -228,6 +230,7 @@ fn list_archive(args: ListCommand) -> io::Result<()> {
             &args.file.files,
             options,
         )
+        .with_context(|| "")
     }
 }
 

cli/src/command/migrate.rs

@@ -25,12 +25,12 @@ pub(crate) struct MigrateCommand {
 
 impl Command for MigrateCommand {
     #[inline]
-    fn execute(self) -> io::Result<()> {
+    fn execute(self) -> anyhow::Result<()> {
         migrate_metadata(self)
     }
 }
 
-fn migrate_metadata(args: MigrateCommand) -> io::Result<()> {
+fn migrate_metadata(args: MigrateCommand) -> anyhow::Result<()> {
     let password = ask_password(args.password)?;
     match args.transform_strategy.strategy() {
         SolidEntriesTransformStrategy::UnSolid => run_transform_entry(
@@ -47,7 +47,8 @@ fn migrate_metadata(args: MigrateCommand) -> io::Result<()> {
             |entry| Ok(Some(strip_entry_metadata(entry?)?)),
             TransformStrategyKeepSolid,
         ),
-    }
+    }?;
+    Ok(())
 }
 
 #[inline]