Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for server #13

Open
ChillerDragon opened this issue Nov 13, 2022 · 4 comments
Open

Add integration tests for server #13

ChillerDragon opened this issue Nov 13, 2022 · 4 comments

Comments

@ChillerDragon
Copy link
Owner

No description provided.

@ChillerDragon ChillerDragon added this to the Publish gem v.0.0.1 milestone Nov 13, 2022
@ChillerDragon
Copy link
Owner Author

ec90f18

One test is there. I would like to see map downloads and another test like chat or something before the the issue can be closed.

ChillerDragon added a commit that referenced this issue Jan 23, 2024
ChillerDragon added a commit that referenced this issue Jan 23, 2024
@ChillerDragon
Copy link
Owner Author

The current state is that the CI gets in a bugged state after the first server test ran.
No other server test can be ran after that.
A possible solution would be multiple jobs but does become annoying to maintain. It does not scale nice. So adding more server tests will be too much effort.

I added a Dockerfile into the integration_tests folder and I could get all tests passing locally once in some half manual docker exec attempt. But that is no way close to being clean/fast or consistent. I even doubt the reproducibility. The gh action yaml for it is ready and tested already but it fails.

@ChillerDragon
Copy link
Owner Author

Okay multiple jobs it is. I moved the setup to a oneliner script. Thats fine maintenance wise. It spams a bunch of jobs but it should still be fast enough.

Adding new tests is now simple.

So the last thing blocking this issue is the server having a test for map download.

@ChillerDragon
Copy link
Owner Author

I had a bunch of crashes happening in the server tick that were not caught by the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant