Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Properties does not work when optgroup on a select #1155

Closed
jbender0 opened this issue May 17, 2024 · 0 comments · Fixed by #1166
Closed

Custom Properties does not work when optgroup on a select #1155

jbender0 opened this issue May 17, 2024 · 0 comments · Fixed by #1166
Labels

Comments

@jbender0
Copy link

I'm using custom properties (inline data attribute) to display a description and thumbnail image. This works fine on a regular select field. But when I add optgroup within the select, it falls apart and only loads the option label. All custom properties are returned as undefined.

The custom property attribute is valid JSON and when I turn off the Choices script it loads correctly with optgroup just fine. So there's definitely a bug in Choices.

Here's a screenshot of it working with no optgroup and after optgroup is added (no thumbnails or custom properties).

Screenshot 2024-05-17 at 1 38 32 PM
Screenshot 2024-05-17 at 1 40 54 PM

Using macOS latest Chrome (v124.0).

Anyone else ran into this bug?

@jbender0 jbender0 added the bug label May 17, 2024
@Xon Xon mentioned this issue Aug 6, 2024
9 tasks
@Xon Xon linked a pull request Aug 6, 2024 that will close this issue
9 tasks
@Xon Xon closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants