Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosers should add link to add #60

Open
inghamn opened this issue Feb 7, 2019 · 2 comments
Open

Choosers should add link to add #60

inghamn opened this issue Feb 7, 2019 · 2 comments
Milestone

Comments

@inghamn
Copy link
Member

inghamn commented Feb 7, 2019

In all of our search forms (streets, addresses, names, etc.) we have a case where we display "no results found". The add button is usually displayed on the search results, rather than in the "no results found".

We need to make sure the add button shows up, especially when there are no results. Also; for our choosers, javascript needs to know to add a link to the "Add" action for whatever is being search for.

@inghamn inghamn added this to the 2.0 milestone Feb 7, 2019
@inghamn
Copy link
Member Author

inghamn commented Apr 12, 2019

Also, javascript needs to know, somehow, if the user actually has permission to add a new thing.

@inghamn
Copy link
Member Author

inghamn commented Apr 15, 2019

I think, to make this happen, we need to update the output response for all searches that implement a non-HTML output.

Currently, I'm just returning the raw search results; however, I think I need to return more of a response object that includes the search results plus any actions the client is allowed to take. The actions would be defined as key=>value url=>labels. That way, the client js can draw the links to the actions when rendering the search results.

This means we need to standardize on a search result response for chooser operations.

@inghamn inghamn modified the milestones: 2.0, 2.1 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant