Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

Disable Log error #45

Open
1 of 4 tasks
carmas123 opened this issue Jul 25, 2018 · 6 comments
Open
1 of 4 tasks

Disable Log error #45

carmas123 opened this issue Jul 25, 2018 · 6 comments
Assignees

Comments

@carmas123
Copy link

Submitting

  • Bug
  • Question
  • Suggetion
  • Other

Please can you add an option to disable the logging into console?

@goriunov
Copy link
Member

To be bale to disable errors to the console you will need to catch them with on('error', () => {}) and/or try, catch other vise it is standard of the browsers (not implemented in to the clusterws).

@carmas123
Copy link
Author

I trace the log exception and I found that the message is created at:
this.websocket = new Socket(this.options.url), this.websocket.binaryType = "arraybuffer",

This must be into a try {} catch {} to be able to handle the exception

@carmas123
Copy link
Author

Otherwise I got always a browser log

@goriunov
Copy link
Member

Ok i will have a look at that. Probably will improve error handling.

@goriunov goriunov self-assigned this Oct 18, 2018
@goriunov
Copy link
Member

goriunov commented Oct 18, 2018

Will go with version 4.0

@carmas123
Copy link
Author

Very good news 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants