Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

My Profile Page #39

Open
sumnerevans opened this issue Jan 17, 2018 · 12 comments
Open

My Profile Page #39

sumnerevans opened this issue Jan 17, 2018 · 12 comments
Assignees

Comments

@sumnerevans
Copy link
Member

sumnerevans commented Jan 17, 2018

Currently, it just shows your name. Make it display useful information.

Useful information

(E) = editable by the user

  • profile pic (E)
  • name (E)
  • title (e.g., "Senior in CS") (E)
  • bio (E)
  • email
  • ACM projects that they are working on (doing in Show user's projects on profile page #36)
  • personal projects that they are working on (E)
  • proficient coding languages (E)
  • link to GitHub account (E)
  • link to StackOverflow account (E)
  • date joined

Requirements

  • users should only be able to edit their own page
  • it should look nice

Questions

  • Should we allow linking of arbitrary social accounts? The problem with this is that it makes usability a bit worse.
    This is pretty easy to add later. Just allow a finite set for now.

  • This is looking a lot like a wiki page that is only editable by one person... should we implement it as such? Problem with this is that it will likely make the profile pages inconsistent. It will fix the problem of adding lots of columns to the User table.
    This is pretty easy to migrate. Just add things to the User model.

Technical Considerations

  • we need to be careful about adding lots of columns to the User table

PR Requirements

Whoever submits a PR on this should include:

  • screenshots of how the page looks with a variety of configurations
@auroraborghi
Copy link

Proficient Coding Languages:
Working Project(s):

@sumnerevans
Copy link
Member Author

@auroraborghi I like it. We are doing some of this in #36 . I'd be willing to allow users to add a list of other, non-ACM, projects.

@auroraborghi
Copy link

Nice! We could also add the users GitHub account and potentially even the date that he/joined the ACM Website.

@jordannewport
Copy link
Contributor

Add the profile picture?

@sumnerevans
Copy link
Member Author

@jordannewport , @auroraborghi , added your suggestions above.

@jordannewport jordannewport self-assigned this Jan 17, 2018
@jackrosenthal
Copy link
Contributor

LUG website implements this (poorly).

Let me know if you want to reap code from there. Might be more useful for views than the crappy logic underneath.

@liamwarfield
Copy link
Contributor

here's a quick sketch of a way we could lay out the page
img_20180117_102313587

@sumnerevans
Copy link
Member Author

@liamwarfield , I like it! Here are a couple comments, these are just my opinions, it's not "gospel truth":

  1. Below the name, before the bio, I think it would be good to have a user-configurable "title". For example, I could put "Vice President, Senior in CS" or something like that. This would be en lieu of the Major on the left side.
  2. For ACM and personal Projects, I think a list of links to the projects that the user is working on would suffice. We can consider showing some sort of abbreviated description, but we don't want to display too much information here.

@samsartor
Copy link
Contributor

samsartor commented Jan 24, 2018

Work is being done in the profile-page branch.

@samsartor
Copy link
Contributor

Layout v2

image

@samsartor
Copy link
Contributor

We want the profile page to be composed of:

  • Header
    • Name
    • Image
    • Tagline
    • Email
    • Github
  • Cards
    • About me
    • Contact info
    • Project A
    • Project B
    • Project ...
    • Plugin thing ...

Each card has a fixed width and height, so that cards fit into an even grid (flow left->right). Each card is self-contained. The profile template simply iterates over card objects, each one renders itself to some arbitrary HTML. Ideally, new card types can be added without editing the user controller source.

@sumnerevans
Copy link
Member Author

Another field we should have on here is PGP Key. This should probably go in contact info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants