Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Pls keep the workflow in the top bar menu #1025

Closed
1 task done
pandayummy opened this issue Sep 27, 2024 · 16 comments
Closed
1 task done

[Feature Request]: Pls keep the workflow in the top bar menu #1025

pandayummy opened this issue Sep 27, 2024 · 16 comments
Labels
enhancement New feature or request

Comments

@pandayummy
Copy link

pandayummy commented Sep 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Workflow list is one of the most frequently used features in ComfyUI, and should be kept in the top menu instead of sidebar.

image

image

Proposed workflow

And the sidebar items should be in this order:

  1. Queue
  2. (Workflows) -- better in top bar menu
  3. (Nodes Map) -- what's the meaning of this? workflow itself is visually friendly, we can operate on any node in the main workspace.
  4. Node Library
  5. (Model Library) -- Model Library is not useful at all, I think. People just use Windows Explorer to manage models.

image

Additional information

And it would be more visually friendly to place all submenu of Settings into the sidebar.
image

@pandayummy pandayummy added the enhancement New feature or request label Sep 27, 2024
@JorgeR81
Copy link

Workflow list is one of the most frequently used features in ComfyUI, and should be kept in the top menu instead of sidebar.

The workflows in the sidebar are better if you have many workflows.

My ideal solution would be to pin / bookmark some saved workflows in the sidebar ( about 3 or 4 for me ), and they will show up in the Topbar pop down menu.


(Nodes Map) -- what's the meaning of this? workflow itself is visually friendly, we can operate on any node in the main workspace.

Where is the Nodes Map ? Is that the bottom icon on your Sidebar ? I don't have it.
Is that from a custom node suite ?


(Model Library) -- Model Library is not useful at all, I think. People just use Windows Explorer to manage models.

The model library will be more useful, when more features are added : #1000

@pandayummy
Copy link
Author

The nodes map might come from EaseUse
image
image

@yoland68
Copy link
Member

How many workflows do you have saved? What is your typical experience of interacting with the workflows in the top menu?

@pandayummy
Copy link
Author

image

All my workflows can be reached in the top menu. It's more convenient than sidebar.

Maybe you can add a scroll bar in the drop down in case of tooo many workflows.

image

@yoland68
Copy link
Member

The top menu is almost the same as side menu here for you. What's the reasoning for your preference for the previous mechanism? Is it mostly existing habits?

@pandayummy
Copy link
Author

It's a habit, and more importantly, when moved to sidebar, I can't distinguish which one is which, they are just some similar icons.

image

I have to click one by one to find what I want. Maybe after sometime I will get used to that to some extent, but will get confused sometimes.

Maybe you can use Text instead of Icons in sidebar menu. That will be more visually friendly. Like those in settings.

image

@yoland68
Copy link
Member

Ya, text definitely would be helpful to help for user education and discoverability here.

@pandayummy
Copy link
Author

Maybe some icons with text on it
image

or

Icon + Text

@JorgeR81
Copy link

JorgeR81 commented Sep 27, 2024

@yoland68, If you decide you add text to the sidebar ( instead of just icons ), please make it optional.

@mijuku233
Copy link
Contributor

Ya, text definitely would be helpful to help for user education and discoverability here.

Additionally, allowing users to adjust the sidebar button position can improve this problem.
Put the workflow browser at the top so that users can find it quickly.

@amimi818
Copy link

I support putting workflow on the sidebar, but it's best to have the corresponding shortcut keys for the sidebar menus (e.g., nodes, workflows).

@camoody1
Copy link

I'd like to jump in here to vote for moving some aspect of opening workflows to the topbar "Workflow" menu. I find it a bit illogical to have some workflow options on the top bar and others in the side bar. It's a bit like having a refrigerator on one side of the kitchen and a freezer on the other side. It just doesn't make much sense to my brain. Also, having the Workflows listed in the sidebar means that I have to click a sidebar button to first open the workflow list, then resize the sidebar so I can read my workflow names, then select a workflow, and finally click the sidebar button AGAIN to close the sidebar. That's a lot of clicks to just open a workflow. It seems much easier to have a droplist from the topbar Workflows menu, just as you had with the previous iteration of the front-end.

@JorgeR81
Copy link

I think we could have both.

The sidebar is already a "duplication" of other features ( e.g. node library vs adding nodes via right click menu ).
The sidebar is usually less convenient to use, unless we need to select items from a very long list ( if you have many workflows; custom nodes, models, etc. ... ) so I think there is a place for both methods.

@LukeG89
Copy link

LukeG89 commented Sep 30, 2024

I agree with @camoody1, and also the workflow tab on sidebar is pretty inconvenient since you have to close the other tabs (Queue, Node Library, Model Library, etc.) in order to access the workflows.
The best solution in my opinion would be:

  • Merging workflow dropdown menu and workflow tab together
    • Only one place to manage workflows
  • Moving workflow tab back on topbar to make it independent from the others
    • This way, you can easy open/switch workflows and keep one tab open

@camoody1
Copy link

I think we could have both.

The sidebar is already a "duplication" of other features ( e.g. node library vs adding nodes via right click menu ). The sidebar is usually less convenient to use, unless we need to select items from a very long list ( if you have many workflows; custom nodes, models, etc. ... ) so I think there is a place for both methods.

I'd like to add that I love having the Node list in the side bar. I love being able to search for nodes easily and pinning my favorites. There is definitely no need to change that functionality. 👍🏼

@huchenlei huchenlei closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
@camoody1
Copy link

camoody1 commented Oct 4, 2024

Booooo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants