Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fullscreen changes draggable menu position #1039

Closed
LukeG89 opened this issue Sep 28, 2024 · 3 comments
Closed

[Bug]: Fullscreen changes draggable menu position #1039

LukeG89 opened this issue Sep 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@LukeG89
Copy link

LukeG89 commented Sep 28, 2024

Frontend Version

1.3.3

Expected Behavior

If you place the menu at the bottom of the screen, the menu should keep its position every time you enter or exit fullscreen.

Actual Behavior

When entering and exiting fullcreen, the position of the menu changes.

Steps to Reproduce

Fullscreen_Issue.mp4

Debug Logs

No errors

Browser Logs

No errors

What browsers do you use to access the UI ?

Google Chrome

Other

No response

@LukeG89 LukeG89 added the Potential Bug Untriaged bug label Sep 28, 2024
@JorgeR81
Copy link

JorgeR81 commented Oct 1, 2024

It would be nice if the floating menu position was dynamically adjusted, when it's placed near the bottom, and also near the top of the canvas.

If we have many workflows open and the Top Bar is in a 2 row configuration, it will be partially covered by the floating menu.

wf11

@mcmonkey4eva mcmonkey4eva added bug Something isn't working and removed Potential Bug Untriaged bug labels Oct 3, 2024
@mcmonkey4eva
Copy link
Contributor

Confirmed, have seen the same. I saw even worse too: with some browser resizes, the bar goes off the bottom of the screen and becomes unusable
This needs, imo, two fixes:

  • 1: Boundary boxes. It should be blocked from going past the edges of the screen
  • 2: autoanchoring. That is: if it's near the bottom of the screen, when the screen is resized, it should retain its position relative to the bottom (say eg it was 200px above bottom before a resize, it needs to be 200px above bottom after a resize). Similarly, if near the top, it should instead retain position relative to the top. Same idea for left/right.

@LukeG89
Copy link
Author

LukeG89 commented Oct 10, 2024

This commit fixed the issue I reported (not the one reported by @JorgeR81): 2d5faa7

But after the implementation of the docking Queue Menu, it doesn't make sense to keep it under the topbar.
So, I close the issue.

@LukeG89 LukeG89 closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants