Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table headers? #96

Open
liusida opened this issue Jun 14, 2024 · 5 comments
Open

Table headers? #96

liusida opened this issue Jun 14, 2024 · 5 comments

Comments

@liusida
Copy link

liusida commented Jun 14, 2024

(Comfy) [clash] PS C:\ComfyUI> comfy node show all
Execute from: C:\ComfyUI\comfy-dummy
[ComfyUI-Manager]  'distutils' package not found. Activating fallback mode for compatibility.
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
[    ENABLED    ]  ComfyUI-Manager                                    manager              (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI-Impact-Pack                                impact               (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI-Inspire-Pack                               inspire              (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI_experiments                                comfy-exp            (author: comfyanonymous)
[ NOT INSTALLED ]  ComfyUI_TensorRT                                   tensorrt             (author: comfyanonymous)
[ NOT INSTALLED ]  ComfyUI-SAI_API                                    sai-api              (author: Stability-AI)

It would be great to have a header for this table, what are in the second column? what are in the third one? I am not sure.

@liusida
Copy link
Author

liusida commented Jun 14, 2024

I guess they are from the json file: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json

        {
            "author": "Sida Liu",
            "title": "ComfyUI-Login",
            "id": "login",
            "reference": "https://github.com/liusida/ComfyUI-Login",
            "files": [
                "https://github.com/liusida/ComfyUI-Login"
            ],
            "install_type": "git-clone",
            "description": "A simple password to protect ComfyUI."
        },

Right?

How is this related to ComfyUI Registry? How can users install custom nodes in the ComfyUI Registry?

@robinjhuang
Copy link
Member

@liusida ComfyUI manager will support installing from the registry very soon. For now you can install using comfy node registry-install <node>. It is a beta feature right now so might have bugs.

@robinjhuang robinjhuang transferred this issue from Comfy-Org/registry-backend Jun 15, 2024
@ltdrdata
Copy link
Member

ltdrdata commented Jun 15, 2024

@liusida ComfyUI manager will support installing from the registry very soon. For now you can install using comfy node registry-install <node>. It is a beta feature right now so might have bugs.

Since there are differences between the current installation method using registry-install and the future method that will be supported by ComfyUI-Manager, caution is needed regarding this matter.

When managing with ComfyUI-Manager, it will use an explicitly displayed directory name in the format <node-id>@<version>. To support updates, a .tracking file will be created during the installation phase.

Nodes installed using registry-install will cause issues due to the lack of assurance for those two aspects.

@liusida
Copy link
Author

liusida commented Jun 16, 2024

I thought everything is ready since @haohaocreates created two PRs for each one of my custom nodes. xD

@ltdrdata
Copy link
Member

You can do pre-test via feat/cnr branch in ComfyUI-Manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants