From de1f00d2e6b2823e3e29f03cc79468d182b98269 Mon Sep 17 00:00:00 2001 From: Jorge Araya Navarro Date: Wed, 30 Oct 2024 12:32:47 -0600 Subject: [PATCH] Rewrite comment in code (#248) Thanks to @jirwin for the clarification --- pkg/cli/commands.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/cli/commands.go b/pkg/cli/commands.go index 26fc0997..c4c261a3 100644 --- a/pkg/cli/commands.go +++ b/pkg/cli/commands.go @@ -271,7 +271,9 @@ func MakeGRPCServerCommand( return err } - // NOTE (shackra): I don't understand this goroutine + // Avoid zombie processes. If the parent dies, this + // will cause Stdin on the child to close, and then + // the child will exit itself. go func() { in := make([]byte, 1) _, err := os.Stdin.Read(in)