Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More imgui widgets #8

Open
dromer opened this issue Jan 27, 2023 · 7 comments
Open

More imgui widgets #8

dromer opened this issue Jan 27, 2023 · 7 comments

Comments

@dromer
Copy link
Collaborator

dromer commented Jan 27, 2023

Thought to collect some possible imgui widgets here:

https://github.com/cmdwtf/imgui_toggle - nice looking toggle switches - 0BSD
https://github.com/dalerank/imspinner - collection of animated spinner icons - MIT

@dromer
Copy link
Collaborator Author

dromer commented Mar 8, 2023

Hmm, seems imgui_toggle breaks rules 1 and 6 since it contains more than one header and has several implementation files.

Unfortunate, since these do look quite nice.

@dromer dromer closed this as completed Mar 8, 2023
@dromer dromer reopened this Mar 8, 2023
@dromer
Copy link
Collaborator Author

dromer commented Mar 9, 2023

Seems imspinner requires c++14 to work:

../../../dpf-widgets/opengl/DearImGuiSpinner/imspinner.h:150:24: error: use of ‘auto’ in lambda parameter declaration only available with ‘-std=c++14’ or ‘-std=gnu++14’

@falkTX
Copy link
Contributor

falkTX commented Mar 9, 2023

This is not going to scale if we keep adding more widgets to imgui stuff. this toggle and knob are quite essential, so I let them pass, just dont assume it is always the case.

Regarding C++14 requirement, yeah it is preferred we keep it C++11 so the code needs tweaking.
Other imgui based things are C++11, so let's not bump the requirement just for 1 single line of code.

@dromer
Copy link
Collaborator Author

dromer commented Mar 9, 2023

Yeah agree, besides those spinners are not critical in any way just thought they looked cool ;)

Actually the imgui_toggle says it might be included in upstream imgui at some point: https://github.com/cmdwtf/imgui_toggle#future-considerations - will probably take a while, but by then we can clean it up from the inclusion perhaps.

@falkTX
Copy link
Contributor

falkTX commented Mar 9, 2023

Personally think the spinners are quite optional and we dont need them by default.

Out of the other widgets I have seen, only the nodes one would be ideal to have, but it needs some tweaking to work well for audio graph/patchbay purposes.

We can always manually include imgui based widgets on plugin gui code, alike done in master_me with the implot, see https://github.com/trummerschlunk/master_me/blob/master/plugin/widgets/Histogram.hpp

@dromer
Copy link
Collaborator Author

dromer commented Mar 30, 2023

re node editor, which of these do you think is better?

Very much leaning towards the second one.

Any other DPF patching plugin ideas floating already?

@dromer
Copy link
Collaborator Author

dromer commented Apr 20, 2024

We were discussing sending midi notes from the UI and I came across: https://github.com/shric/midi/blob/master/src/Piano.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants