Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ubuntu 20.04 in CI #35

Merged
merged 1 commit into from
Dec 22, 2023
Merged

use ubuntu 20.04 in CI #35

merged 1 commit into from
Dec 22, 2023

Conversation

joergbrech
Copy link
Collaborator

@joergbrech joergbrech commented Dec 22, 2023

After #29 was merged, Ubuntu 20.04 CI started failing at https://github.com/dlr-sc/tigl due to a glibc conflict. Ubuntu 22.04 builds seem to be uneffected. This PR is a desperate attempt to see if building the packages on Ubuntu 20.04 resolves this issue.

@rainman110
Copy link
Collaborator

You don't need to be desperate ;). I think it will work. You could even think of using an even older ubuntu, to have even larger support for different linux distros.

@joergbrech
Copy link
Collaborator Author

joergbrech commented Dec 22, 2023

You don't need to be desperate ;). I think it will work. You could even think of using an even older ubuntu, to have even larger support for different linux distros.

Phew, I am relieved 😝

Currently, Github runners are Ubuntu 20.04 and 22.04 only, and I am guessing Ubuntu 20.04 will be dropped some time next year. To support older distros we would have to build everything in seperate docker containers.

For now, I am happy with a quick fix so that our TiGL CI works again. Supporting older distros could be implemented as part of another issue/pr.

@rainman110
Copy link
Collaborator

rainman110 commented Dec 22, 2023

Supporting older distros could be implemented as part of another issue/pr.

I totally agree. I think it would be wise to use the same distros as conda-forge, maybe even the same docker container.
(quay.io/condaforge/linux-anvil-cos7-x86_64)

@joergbrech joergbrech merged commit 8cb7593 into master Dec 22, 2023
30 checks passed
@joergbrech joergbrech deleted the ubuntu-20.04 branch December 22, 2023 17:54
@joergbrech
Copy link
Collaborator Author

It turns out my desperation was completely appropriate ;)

#36 was needed to fix the issue.

@rainman110
Copy link
Collaborator

Very strange. Conda build comes with it's own GCC version 8 oder so. Cmake should use this compiler instead of the one provided by Ubuntu.

@joergbrech
Copy link
Collaborator Author

joergbrech commented Dec 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants