Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit sbr + ps not working #8

Open
dieterstueken opened this issue Jan 6, 2018 · 0 comments
Open

implicit sbr + ps not working #8

dieterstueken opened this issue Jan 6, 2018 · 0 comments

Comments

@dieterstueken
Copy link

I failed to decode any he-aac plus v2 (AAC + SBR + PS) stream.
After several nights of debugging against faad2 (C-code) I found several bugs.
Concerning SBR I prepared a pull request.
Implicit PS did not work, too. The function SBR.processPS() was not called at all.
The output channel is prepared as mono and can not be switched to stereo easily.
As a workaround I upgraded all mono streams to stereo.
All the bugs I found in the original code too.

Dieter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant