Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of screen reader Accessibility #94

Open
TonPh2238 opened this issue Mar 24, 2024 · 6 comments
Open

Lack of screen reader Accessibility #94

TonPh2238 opened this issue Mar 24, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@TonPh2238
Copy link

Hello,
I was looking for a plugin that would be able to convert my acoustic recordings to MIDI without the extra trouble of having to replay it on a digital instrument just to get the MIDI file I need. So far Neuralnote works great, it’s incredibly accurate and fast once it’s picked up on the source file. There is a big issue though, I’m a blind user on windows with the NVDA screen reader and Reaper as my DAW. When I insert Neuralnote, only the record button is labeled and then the playback button after it has picked up on the audio I play from a different track. There seems to be no way for me to insert audio without recording playback which can be time consuming, and once that audio is recorded I don’t have access to the three knobs: “note sensability”, “split”, “min note duration”. I needed sighted help to adjust those and there doesn’t seem to be a way to save the MIDI or export it straight from the plugin window once I’m satisfied with it. I know that normally you can drag and drop items in and out of the FX window, but that is not possible for me with a screen reader and strangely the tracks seem to disappear once NeuralNote is added, although the latter may be a Reaper exclusive issue.

@DamRsn
Copy link
Owner

DamRsn commented Mar 24, 2024

Hey, thanks for reaching out!

Concerning the inaccessibility for you of the sensitivity, split and min duration knobs, as well as other parameters, there's ongoing work on making those accessible to the DAW as regular parameters. This should make those available just like the recording button.

Regarding the import of an audio file, or the export of the midi file, I'm not sure how I can do this so that it can work easily with your setup. Currently you can drag and drop for audio import and midi export. For audio import, there's also a file chooser that opens when the audio region is clicked. Do you know any import/export technique that I could implement that would make this work well with your setup ?

I'm currently pretty busy with work so I don't have a lot of time to work on NeuralNote, so this may take a little while. But I'm willing to make NeuralNote as accessible as I can.

@TonPh2238
Copy link
Author

TonPh2238 commented Mar 24, 2024 via email

@Timtam
Copy link

Timtam commented Mar 25, 2024

Hi there, just wanted to elaborate further on this:

Adding the parameters to the list of parameters accessible to the DAW will solve those issues, so thanks for that in advance.
Regarding loading audio: its already possible with the help of OCR, although not nice. Right now we need to click onto the text that says "Load a file or drag and drop one here" (or something like it), which will open a typical file open dialog which then continues to work just fine. Could you just turn that one into a typical button so that the screen reader picks it up? That would make things much easier.

And regarding export: just a button that basically copies MIDI into the clipboard so that we can paste it into the DAW would be fine already I guess.

Thanks alot!

@DamRsn
Copy link
Owner

DamRsn commented Mar 26, 2024

Alright I understand. I'll add that when I will finalize the parameter PR.

@DamRsn DamRsn added the enhancement New feature or request label Mar 26, 2024
@DamRsn DamRsn self-assigned this Mar 26, 2024
@Timtam
Copy link

Timtam commented Nov 3, 2024

Hello @DamRsn , thanks for pushing the 1.0 release. I noticed that improved screen reader functionalities like the one mentioned above aren't mentioned in the changelog, did you encounter any issues that we might be able to help with, or did you forget to mention them within the changes?
I'll check out the release ASAP and report back on my findings.
Thanks again!

@DamRsn
Copy link
Owner

DamRsn commented Nov 3, 2024

Hey @Timtam,

Apart from the parameters registered to the DAW change, there's no improvement regarding accessibility yet. But with the other improvements I did on the project, I should now be able to release new versions more quickly.

Yes please, let me know if the parameters (like note sensibility, split sensibility ...) are now accessible via the screen reader.

Concerning import of audio files and export of midi transcription, I will see how I can add regular buttons that are visible to the screen reader. One idea I'm having: I've added a "Settings" button, that shows a dropdown with only one option at the moment (Midi Out). If you're able to access it, I could add two more options:

  • Load audio file
  • Export transcription to midi file
    Both options would open a file explorer window.

Let me know if this would work for you.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants