Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal serialize performance! #530

Open
mbtolou opened this issue Sep 26, 2024 · 2 comments
Open

decimal serialize performance! #530

mbtolou opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mbtolou
Copy link

mbtolou commented Sep 26, 2024

image

Hi, I used JetBrain to benchmark my software. What stands out is the low performance in converting decimals and writing them. Can you check where the problem is?

@DarkWanderer
Copy link
Owner

The reason for this is that I have opted to use BigInteger for ClickHouseDecimal as I wasn't confident in my ability to produce well-optimized Int128/Int256 classes, and there is no current widely used package with both. This is an interesting challenge however, might be time to revisit this

@DarkWanderer DarkWanderer self-assigned this Sep 27, 2024
@DarkWanderer DarkWanderer added the enhancement New feature or request label Sep 28, 2024
@DarkWanderer
Copy link
Owner

As a heads-up - I am looking into this in background, however, it would require rewriting ClickHouseDecimal completely to use blittable fixed-length integer types. The challenge is that from my research, there is no ready-to-use .NET library which has:

  • Int128
  • Int256
  • .NET Framework support

So I'll have to roll my own Int128 and Int256, which need some time to be carefully designed and tested. Bear with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants