Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoder offset not used #16

Open
brettle opened this issue Mar 5, 2024 · 3 comments
Open

Encoder offset not used #16

brettle opened this issue Mar 5, 2024 · 3 comments
Assignees
@FriedLongJohns
Labels
waiting waiting for something else to finish first

Comments

@brettle
Copy link
Member

brettle commented Mar 5, 2024 •
edited
Loading

RobotCode2024/src/main/java/org/carlmontrobotics/Constants.java

Line 43 in 864bd30

public static final double ENCODER_OFFSET_RAD = 0;

This does not appear to be used anywhere. See documentation for setZeroOffset().

Obviously, the value also needs to be set based on the what SysId reports.
@FriedLongJohns FriedLongJohns self-assigned this Mar 6, 2024
@FriedLongJohns
Copy link
Contributor

FriedLongJohns commented Mar 6, 2024 •
edited
Loading

setZero added in 35374d4

@FriedLongJohns
Copy link
Contributor

will need to get from sysid still

@FriedLongJohns FriedLongJohns added the waiting waiting for something else to finish first label Mar 9, 2024
@stwiggy
Copy link
Contributor

stwiggy commented Mar 11, 2024

value added in d3778c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FriedLongJohns FriedLongJohns

Labels
waiting waiting for something else to finish first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettle @FriedLongJohns @stwiggy