Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last step of install wizard should be to delete itself #61

Open
DBJRdev opened this issue Oct 21, 2019 · 2 comments
Open

Last step of install wizard should be to delete itself #61

DBJRdev opened this issue Oct 21, 2019 · 2 comments
Labels
dbjr-approved enhancement New feature or request good first issue Good for newcomers

Comments

@DBJRdev
Copy link
Member

DBJRdev commented Oct 21, 2019

At the moment the install wizard tells you in its last step to go to the server and delete the /install dir. However, it would be much more helpful, if the install wizard offers to do that itself – if the rights for deleting are available.

The wizard deleter should try to delete the following:

  • /install dir
  • epartool-downloader.php script in root (from installer perspective: it's a hierarchy step above, so it's ../epartool-downloader.php )
@mbohal
Copy link
Contributor

mbohal commented Jul 30, 2020

@DBJRdev I'm not sure if it is a good idea to delete the epartool-downloader.php script.

The downloader script is sort of "controlling" the app, in a way it owns it. It is therefore strange for the app to delete the script. Technically there is no problem with this, but were I the user it would confuse me quite a bit - it somehow does not feel right. Like you write yourself:

it's a hierarchy step above

Generally I think that commands and automation should not behave in a way the user does not expect. Deleting the script would in my view break this principle.

We could write it out on screnn but many people, me included, do not read messages until they run into trouble. That however is already too late.

Also there are some edge cases:

  • what if the script is not there?
  • what if the permissions are wrong and it can not be deleted?
  • what if the script has the same name, but is in fact something else unrelated to ePartool?

Please reconsider this.

@DBJRdev
Copy link
Member Author

DBJRdev commented Aug 21, 2020

Understanding your concern from a server admin's point of view, yet the organisations using ePartool struggle with the back and forth between frontend config (wizard) and then switching back to FTP or SSH. Therefore the wizard should offer deletion.

Answers to your questions:

  • When script is not there: do nothing
  • When permissions are wrong: output error message
  • Unrelated script: not our worry, because we officially instruct people to use a blank directory for installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbjr-approved enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants