You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The regexp for float and ints accept arbitrary big numbers and then parses them. If it's too big, it will fail (and not gracefully, at the moment)
I'm not sure what would be a good solution.
Using a regexp that matches only 32 bit integers, while possible, is a terrible idea.
Using zarith is a bit overkill (most application really don't care). And there is the javascript issue.
Wrapping int and floats in an option is really not user friendly.
The only good solution I see is to
Return None for extract. It forces the return type of extract to be an option (which should be the case anyway, but the types are not obvious to me just yet)
Trigger the default handler for match_url.
Maybe the kind of error encountered should be exposed to the user.
The text was updated successfully, but these errors were encountered:
The regexp for float and ints accept arbitrary big numbers and then parses them. If it's too big, it will fail (and not gracefully, at the moment)
I'm not sure what would be a good solution.
The only good solution I see is to
None
forextract
. It forces the return type ofextract
to be an option (which should be the case anyway, but the types are not obvious to me just yet)match_url
.Maybe the kind of error encountered should be exposed to the user.
The text was updated successfully, but these errors were encountered: