Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of enchantments #233

Open
LadyCailinBot opened this issue Dec 29, 2013 · 1 comment
Open

Better handling of enchantments #233

LadyCailinBot opened this issue Dec 29, 2013 · 1 comment

Comments

@LadyCailinBot
Copy link

CMDBOOK-2341 - Reported by Andy

Currently, you can only add enchantments with the /item and /give command if you enter the exact name from org.bukkit.enchantments.Enchantment. Those names aren't all very logical, and some doesn't correspond well to what they are generally called (Which is why the /enchantments command was added I suppose).

I would like to do something about this, and add an /enchant command in InventoryComponent based off the vanilla Minecraft-command with some improvements. In addition to the command handling there would need to be a way to transform user input to Enchantment-values/IDs.

Is this something you might be interested in? Additionally, I'm unsure as to where to send the PR in terms of the lookup-functions. I feel that it might be better to put this class in package com.sk89q.worldedit.blocks since the rest of the Item and Block-class/functions are there, where it may be used by WorldEdit/WorldGuard as well should there ever be a need to (/searchitem is a possibility).

@LadyCailinBot
Copy link
Author

Comment by Andy

Here's what I was thinking for resolving Enchantment names/IDs/Aliases:
andypandy89/worldedit@d03ea61

Its structure is identical to ClothColor.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant