Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PopupViewer: "View" link not localized. #577

Open
dotMorten opened this issue Jun 6, 2024 · 0 comments
Open

PopupViewer: "View" link not localized. #577

dotMorten opened this issue Jun 6, 2024 · 0 comments
Assignees
@mstefarov
Labels
good first issue Good for newcomers Type: Bug
Milestone
200.6

Comments

@dotMorten
Copy link
Member

dotMorten commented Jun 6, 2024 •
edited
Loading

In the popupviewer when there are URLs, the text "View" is shown, but this text hasn't been localized:

arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit/UI/Controls/PopupViewer/FieldsPopupElementView.cs

Line 132 in 44f8d9a

var hl = new Span() { Text = "View", TextDecorations = TextDecorations.Underline };

https://github.com/Esri/arcgis-maps-sdk-dotnet-toolkit/blob/44f8d9a21a14759e4edaf6569fcaceea7023a2a9/src/Toolkit/Toolkit/UI/Controls/PopupViewer/FieldsPopupElementView.cs#L149C36-L149C42

Reported here: #555 (comment)
@dotMorten dotMorten added good first issue Good for newcomers Type: Bug labels Jun 6, 2024
@dotMorten dotMorten added this to the 200.5 milestone Jul 2, 2024
@dotMorten dotMorten modified the milestones: 200.5, 200.6 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstefarov mstefarov

Labels
good first issue Good for newcomers Type: Bug
Projects
None yet
Milestone
200.6
Development

No branches or pull requests
2 participants
@mstefarov @dotMorten