[T9n] "messages" prop no longer needs to be exposed for usage in tests #10399
Labels
1 - assigned
Issues that are assigned to a sprint and a team member.
blocked
This issue is blocked by another issue.
calcite-components
Issues specific to the @esri/calcite-components package.
estimate - 2
Small fix or update, may require updates to tests.
needs milestone
Planning workflow - pending milestone assignment, has priority and/or estimate.
refactor
Issues tied to code that needs to be significantly reworked.
Description
Blocked by #10310
Every Calcite component declares
messages
as an undocumented prop for usage in tests.calcite-design-system/packages/calcite-components/src/components/chip/chip.tsx
Lines 118 to 124 in f50c170
I believe the only usage in tests was this place:
calcite-design-system/packages/calcite-components/src/tests/commonTests/t9n.ts
Lines 36 to 38 in f50c170
In Lumina, exposing
messages
as a prop is not necessary. Instead, the test can access internal component members in the following way:The
manager
property is the same both on the html proxy element and on the actual lit component. It has acomponent
property for accessing the lit component (in turn,component
has anel
property for accessing the html proxy).This property is not part of public typings or public documentation - it's for internal usage only.
Proposed Advantages
Slight performance improvement and bundle size reduction because
messages
property would no longer need to be included in the lazy-loading metadata for each component.Which Component
All
Relevant Info
No response
Calcite package
The text was updated successfully, but these errors were encountered: