Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] remove ban-props-on-host ESLint rules #10422

Open
maxpatiiuk opened this issue Sep 27, 2024 · 1 comment
Open

[ESLint] remove ban-props-on-host ESLint rules #10422

maxpatiiuk opened this issue Sep 27, 2024 · 1 comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 27, 2024

Priority impact

p - low

Summary

Blocked by #10310

Calcite developed an ban-props-on-host ESLint rule.
Such rule is not applicable in Lumina because <Host> does not exist in Lit.

Instead, you can set props or attributes imperatively inside of connectedCallback or render.
It seems like Stencil's <Host> didn't check if attributes were already set by the user and would overwrite them. Imperatively, you can use ??= instead of = when assigning props to avoid overwriting existing value.
The codemod takes care of migrating all <Host> usages.

Desired Outcome

After migrating to Lumina, remove the ban-props-on-host ESLint rule.

Resources

No response

@maxpatiiuk maxpatiiuk added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 27, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 27, 2024
@maxpatiiuk
Copy link
Member Author

Blocked by #10310

@maxpatiiuk maxpatiiuk added the blocked This issue is blocked by another issue. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Development

No branches or pull requests

1 participant