Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint] Remove require-event-emitter-type rule #10423

Open
maxpatiiuk opened this issue Sep 27, 2024 · 0 comments
Open

[ESLint] Remove require-event-emitter-type rule #10423

maxpatiiuk opened this issue Sep 27, 2024 · 0 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.

Comments

@maxpatiiuk
Copy link
Member

Priority impact

p - low

Summary

Blocked by #10310

Calcite developed an require-event-emitter-type ESLint rule.
Such rule is not necessary in Lumina because the default event emitter type is void rather than any.
Also, if event emitter type is not void, then the first argument in .emit() is mandatory (in Stencil it was always optional, leading to possible bugs if you forgot to provide the payload)

Desired Outcome

Remove the require-event-emitter-type ESLint rule after the migration.

Resources

No response
@maxpatiiuk maxpatiiuk added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 27, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 27, 2024
@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfranco @maxpatiiuk