Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inline-editable] provide way to add tooltip for controls #10536

Closed
2 of 6 tasks
ptmdmusique opened this issue Oct 14, 2024 · 2 comments
Closed
2 of 6 tasks

[inline-editable] provide way to add tooltip for controls #10536

ptmdmusique opened this issue Oct 14, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-10-29 - Oct ...

Comments

@ptmdmusique
Copy link
Contributor

Check existing issues

Summary

There is a request from AGO PE to add tooltips for the controls (✔️, ✏, and ❌) to improve the accessibility of the consumer components of the inline-editable

There is a messageOverrides prop but it doesn't get forwarded to any native HTML tooltip prop such as title

Actual Behavior

No way to enable tooltips for controls

Expected Behavior

There should be a prop to enable such tooltips

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/inline-editable/

Reproduction Steps

  1. Hover over the controls, no tooltip appears

Reproduction Version

latest

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@ptmdmusique ptmdmusique added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Oct 14, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Oct 14, 2024
driskull added a commit that referenced this issue Oct 14, 2024
@driskull
fix(inline-editable): use native tooltips for controls. #10536
f622c2d
@driskull driskull mentioned this issue Oct 14, 2024
Merged
@DitwanP DitwanP added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. 1 - assigned Issues that are assigned to a sprint and a team member. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Oct 14, 2024
@DitwanP DitwanP added this to the 2024-10-29 - Oct Milestone milestone Oct 14, 2024
driskull added a commit that referenced this issue Oct 21, 2024
@driskull
fix(inline-editable): add tooltips for controls (#10538)
637ddfe 
**Related Issue:** #10536

## Summary

- add `title` attribute for controls
- change message text to remove "click to"
- add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 21, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 21, 2024
@geospatialem
Copy link
Member

Verified in 2.14.0-next.15 for the component's "Edit" button, and when controls is present, the "Cancel" and "Save" buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
4 participants
@driskull @geospatialem @ptmdmusique @DitwanP