Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block] Expose Loader "type" property #10539

Open
1 of 6 tasks
jacqueskeet opened this issue Oct 14, 2024 · 2 comments
Open
1 of 6 tasks

[Block] Expose Loader "type" property #10539

jacqueskeet opened this issue Oct 14, 2024 · 2 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@jacqueskeet
Copy link

Check existing issues

Description

Currently, the Block component lacks the ability to control the loader type (e.g., determinate, indeterminate, determinate-value). This limitation restricts customisation and flexibility in certain scenarios.

Acceptance Criteria

  • The loaderType prop is successfully added to the Block component.

Relevant Info

@SkyeSeitz @macandcheese @ashetland

Which Component

block

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@jacqueskeet jacqueskeet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 14, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Oct 14, 2024
@jacqueskeet jacqueskeet added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 14, 2024
@macandcheese
Copy link
Contributor

macandcheese commented Oct 14, 2024 •
edited
Loading

We should also provide a ‘loading-value’ or similar prop alongside this for the ‘determinate’ use case.

@COV-GIS
Copy link

COV-GIS commented Oct 15, 2024

#9972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@macandcheese @COV-GIS @jacqueskeet