Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Select all for combobox #2311

Open
jgibson02 opened this issue Jun 11, 2021 · 9 comments
Open

Enhancement: Select all for combobox #2311

jgibson02 opened this issue Jun 11, 2021 · 9 comments
Labels
0 - new New issues that need assignment. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@jgibson02
Copy link
Contributor

jgibson02 commented Jun 11, 2021

Description

Provide a way to include a "select all/none" button for a pick-list Combobox

Acceptance Criteria

Relevant Info

Which Component

pick-list Combobox

Example Use Case

In ArcGIS Velocity we have a page with a data grid for items with a dropdown filter for item status (currently a calcite-react MultiSelect):
image
image
image

We decided to add a "select all/none" button to the list since it's common for a user to want to quickly filter down to a single/few status types but then want to go back to seeing everything.

@jgibson02 jgibson02 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 11, 2021
@macandcheese
Copy link
Contributor

macandcheese commented Jun 11, 2021

Super valid. Some thoughts:

  • This should be an opt-in functionality.
  • This has also come up about the combobox as well, so any solution should be designed with both of these components in mind (dropdown multi-select too ?).
    • For combobox, this might require a new prop (also valid without the select-all use case), max-displayed-chips (?), any chips after which are appended to a “+n” chip.
    • Invokes the follow up question, “can you click the "+n" chip to show those items”

@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Jun 11, 2021
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Jul 29, 2021
@jcfranco jcfranco added this to the Backlog milestone Jul 29, 2021
@bstifle
Copy link

bstifle commented Jul 30, 2021

Here's my design for this!

Was thinking the "Select all" label could be authored however the terminology seems fit. Same with the "all items" chip

select all

@jgibson02 jgibson02 changed the title Enhancement: Select all/none for pick-list Enhancement: Select all/none for pick-list/dropdown/combobox Sep 23, 2021
@macandcheese
Copy link
Contributor

I think we'll want to re-evaluate the above design - I also don't think this is valid for Dropdown.

The screenshot workflow in OP is valid for Combobox as shown, but likely also Pick List as described. @asangma do you have thoughts on select / deselect workflow in pick List?

Do we want to separate this out to scope the enhancements to Combobox from those to Pick List?

@jcfranco
Copy link
Member

jcfranco commented Jan 7, 2022

Do we want to separate this out to scope the enhancements to Combobox from those to Pick List?

I think separate issues would be good. Do we also need to include the value list too? cc @benelan

@geospatialem geospatialem changed the title Enhancement: Select all/none for pick-list/dropdown/combobox Enhancement: Select all/none for list/dropdown/combobox Mar 3, 2023
@geospatialem geospatialem added the p - medium Issue is non core or affecting less that 60% of people using the library label Mar 3, 2023
@geospatialem
Copy link
Member

Related combobox issues with select all: #2162, #3074, #4738

@brittneytewks brittneytewks added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@ashetland ashetland added the c-combobox Issues that pertain to the calcite-combobox and related components label Apr 3, 2023
@geospatialem
Copy link
Member

Reassigning to June for design considerations prior to development.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jul 7, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

cc @geospatialem, @brittneytewks

@github-actions github-actions bot removed this from the Design Sprint milestone Jul 7, 2023
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jul 10, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@ashetland ashetland added the design Issues that need design consultation prior to development. label Sep 7, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

8 participants