Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strict-boolean-attributes rule from the provided config #9089

Open
1 of 5 tasks
Elijbet opened this issue Apr 8, 2024 · 1 comment
Open
1 of 5 tasks

Remove strict-boolean-attributes rule from the provided config #9089

Elijbet opened this issue Apr 8, 2024 · 1 comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-12-17 - Dec ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Apr 8, 2024

Description

Disable/remove strict-boolean-attributes custom esLint plugin rule from the recommended config as it is no longer needed with Stencil v4.14.1 and can be replaced by ban-default-true.

Proposed Advantages

Reduces the number of unnecessary checks performed during linting.
Ensures that the ESLint configuration remains current with the latest best practices.

Which Component

@esri/eslint-plugin-calcite-components

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 8, 2024
@github-actions github-actions bot added the eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. label Apr 8, 2024
@Elijbet Elijbet changed the title Remove strict-boolean-attributes rule as no longer needed Remove strict-boolean-attributes rule from the provided config Apr 8, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@jcfranco
Copy link
Member

jcfranco commented Sep 27, 2024 •
edited
Loading

We might still need this after #10310.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @Elijbet