Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pagination] Enhance component's interactive states #9991

Closed
7 of 11 tasks
geospatialem opened this issue Aug 7, 2024 · 3 comments
Closed
7 of 11 tasks

[Pagination] Enhance component's interactive states #9991

geospatialem opened this issue Aug 7, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-10-29 - Oct ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Aug 7, 2024 •
edited by DitwanP
Loading

Check existing issues

Description

Updates the pagination interactive states as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

  • Add 2px gap between all of the component's elements
  • Update chevron icon on :hover and :pressed to text.1 (currently brand)
  • Update background color on :pressed to foreground.3
  • Update inactive page :pressed to text.1 and foreground.3
  • Increase active state :focus bottom border to 4px

image

Relevant Info

Figma file

Which Component

pagination

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. ready for dev Issues ready for development implementation. labels Aug 7, 2024
@github-actions github-actions bot added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. Calcite (design) Issues logged by Calcite designers. labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 7, 2024
@geospatialem geospatialem mentioned this issue Aug 7, 2024
Open
27 tasks
@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 8, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@aPreciado88 aPreciado88 self-assigned this Oct 2, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 2, 2024
This was referenced Oct 3, 2024
Merged
Closed
aPreciado88 added a commit that referenced this issue Oct 9, 2024
@aPreciado88
feat(pagination): enhance component's interactive states (#10485)
a26db31 
**Related Issue:**
[#9991](#9991)

## Summary

- Add `2px` gap between all of the component's elements.
- Update chevron icon on `:hover` and `:pressed` to `text-color-1`
(currently `brand`).
- Update `background-color` on `:pressed` to `bg-foreground-3`.
- Update inactive page `:pressed` to `text-color-1` and
`bg-foreground-3`.
- Increase active state `:focus` `bottom-border` to `4px`.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Installed and assigned for verification.

@aPreciado88 aPreciado88 added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Oct 9, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 14, 2024

🍡 Verified on 2.14.0-next.13
https://codepen.io/Ditwan-Price/pen/qBerpEQ?editors=1000

@DitwanP DitwanP closed this as completed Oct 14, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88