Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useAccountManager popup improvements #465

Open
am-maneaters opened this issue Apr 9, 2021 · 1 comment · May be fixed by #472
Open

useAccountManager popup improvements #465

am-maneaters opened this issue Apr 9, 2021 · 1 comment · May be fixed by #472
Assignees

Comments

@am-maneaters
Copy link
Contributor

am-maneaters commented Apr 9, 2021

Few ideas I had for improving useAccountManager, mostly when using popup.

  • improved status checking

    • check if popup window is currently open
    • something like const {popupOpen: boolean} = useAccountManager()
      for example: this would make it easy to display a loader on the base website while the authentication is happening in the popup window (i.e. {popupOpen && })
  • callback events

    • something like useAccountManager(options, onAccountAdded : () => {}, onAccountRemoved: () => {}, onAccountsUpdated:: () => {}, onAuthCancelled: () => {})
      ex: in table editor, after authentication is finished, i want to use a callback to execute some cmds. here's how i do it now:

image

@codylawson
Copy link
Contributor

@samMatenaer These are great recommendations, @brandonlammey any thoughts?

@brandonlammey brandonlammey self-assigned this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants