Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule source of build code #65

Open
gavinr opened this issue Mar 11, 2019 · 3 comments
Open

Submodule source of build code #65

gavinr opened this issue Mar 11, 2019 · 3 comments
Assignees

Comments

@gavinr
Copy link
Contributor

gavinr commented Mar 11, 2019

The Esri Web AppBuilder team is now storing the original build files (that this tool uses) on GitHub. In order to reduce duplication of code efforts, one idea was to use the Submodules feature to refer to that code in this repository. So then this repository would be primarily focused on providing the CLI to the build, but the actual build code would be handled over in that repository.

@kevinsagis
Copy link

I am confused now... That repo https://github.com/Esri-DevCenter-Beijing/wab-app-build-script looks like it aims to do the same thing. Is this Esri-wab-build repo more up to date or what is the difference? Which one should we use? This one?

@kevinsagis
Copy link

Also still sitting on the fence and waiting. I was thinking I'd wait for WAB 2.12 to drop, then, try this Builder in hopes it will actually work, and bring production viewers up to par with this combo if it is working. I still think Esri may want to consider making this an official part of the Dev Edition of WAB.

@gbochenek
Copy link
Contributor

Hi @kevinsagis,

The repo found on the Esri-DevCenter-Beijing page is maintained by the core Web AppBuilder team and accomplishes a very similar end goal as this one. In fact, this repo is essentially a wrapper around an older version of that script providing for easier developer tooling.

Since that version of the repo is able to be updated more regularly than this one, this issue hopes to formalize the wrapper status of this project by including it as a sub-module of this one. That way, any updates to that repo will be more easily applied to this one. If you wanted to take a look at this issue, I would start by reviewing how app/buildTool.js is loaded from app/build and finding an entry into https://github.com/Esri-DevCenter-Beijing/wab-app-build-script we could use in its place.

If you are having issues with the current release of this tool against a specific version, that would be better addressed as its own issue.

Thanks!

@gavinr gavinr pinned this issue Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants