Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify physics kernels which are not covered by unit tests and write tests for them #223

Open
ddement opened this issue Jul 24, 2024 · 5 comments
Assignees
Labels
code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc. testing Related to unit tests, regression tests etc.

Comments

@ddement
Copy link
Collaborator

ddement commented Jul 24, 2024

Task: Write unit tests for all physics related kernels to ensure full test coverage of this aspect of our code. A "physics kernel" is a function object which computes values for updating the state. These are likely located in the system, constraints, and state folders. This does not include the "high level" functions found in the step folder, which pass data from our data structures to the physics kernels.

Why: Unit tests are a good, and this code has previously been covered by regression and integration testing primarily.

Done means: All of these kernels have at least one unit test, preferably more if necessary to cover obvious variations in functionality.

@ddement ddement added code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc. testing Related to unit tests, regression tests etc. labels Jul 24, 2024
@ddement ddement self-assigned this Jul 24, 2024
@ddement ddement changed the title Add unit tests for physics kernels in the solver folder Identify physics kernels which are not covered by unit tests and write tests for them Sep 13, 2024
@ddement
Copy link
Collaborator Author

ddement commented Sep 13, 2024

Note: title changed to reflect change in code structure, which moved all of the physics logic out of the solver folder

@michaelasprague
Copy link
Contributor

In progress and making progress.

@michaelasprague
Copy link
Contributor

In progress; writing unit tests.

@michaelasprague
Copy link
Contributor

Almost done.

@michaelasprague
Copy link
Contributor

One more constraint; maybe done today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc. testing Related to unit tests, regression tests etc.
Projects
None yet
Development

No branches or pull requests

2 participants