You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
at work we use X-Ray, and using the AWS X-Ray for SQL tracing would force us to rewrite all of our code.
We are investigating the use of this package (and keeping an eye on @luna-duclos fork), but we have some questions about some of the decisions.
some calls that receive a query string do not include it as a label. For example, PrepareContext . Can someone elaborate why not? Is there a reason for this decision?
On Open doesn't it make sense to keep track of the name parameter to include in the Spans?
I used to maintain this package, and now maintain my fork, so I can answer these:
These were just oversights
The open call takes all kinds of sensitive information like potential passwords, I am not sure its a good idea to include it in trace spans ? Though perhaps as an option disabled by default could be acceptable
Hi,
at work we use X-Ray, and using the AWS X-Ray for SQL tracing would force us to rewrite all of our code.
We are investigating the use of this package (and keeping an eye on @luna-duclos fork), but we have some questions about some of the decisions.
query
string do not include it as a label. For example,PrepareContext
. Can someone elaborate why not? Is there a reason for this decision?Open
doesn't it make sense to keep track of thename
parameter to include in the Spans?This is all for now :), thank you for your time.
\cc @pcruz7
The text was updated successfully, but these errors were encountered: