Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: X-Ray support #9

Open
melo opened this issue Jan 23, 2018 · 1 comment
Open

RFC: X-Ray support #9

melo opened this issue Jan 23, 2018 · 1 comment

Comments

@melo
Copy link

melo commented Jan 23, 2018

Hi,

at work we use X-Ray, and using the AWS X-Ray for SQL tracing would force us to rewrite all of our code.

We are investigating the use of this package (and keeping an eye on @luna-duclos fork), but we have some questions about some of the decisions.

  1. some calls that receive a query string do not include it as a label. For example, PrepareContext . Can someone elaborate why not? Is there a reason for this decision?
  2. On Open doesn't it make sense to keep track of the name parameter to include in the Spans?

This is all for now :), thank you for your time.

\cc @pcruz7

@luna-duclos
Copy link
Contributor

Hey there,

I used to maintain this package, and now maintain my fork, so I can answer these:

  1. These were just oversights
  2. The open call takes all kinds of sensitive information like potential passwords, I am not sure its a good idea to include it in trace spans ? Though perhaps as an option disabled by default could be acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants