Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a reasonable min supported Android version #14014

Closed
Julesssss opened this issue Jan 5, 2023 · 22 comments
Closed

Set a reasonable min supported Android version #14014

Julesssss opened this issue Jan 5, 2023 · 22 comments
Assignees
@Julesssss
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Jan 5, 2023 •
edited by melvin-bot bot
Loading

Problem

We currently support Android devices as far back as Android 5.0. This is very old and requires that we support devices used by less than <1% of our users. This requires additional support for old versions, and sometimes requires that we implement specific code to handle old and new/Android versions differently.

Android SDK useage

Solution

Set a reasonably valid supported Android version, based on the current amount of users on lower Android versions. Perhaps Android 7 is a good starting point.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fedc73e1218c2523
  • Upwork Job ID: 1610955297230606336
  • Last Price Increase: 2023-01-05
@Julesssss Julesssss added Engineering Monthly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jan 5, 2023
@Julesssss Julesssss self-assigned this Jan 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fedc73e1218c2523

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 5, 2023
@Julesssss
Copy link
Contributor Author

On hold for now

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 17, 2023
@Julesssss
Copy link
Contributor Author

Not a priority

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 23, 2023
@Julesssss
Copy link
Contributor Author

Still not a priority

@melvin-bot melvin-bot bot removed the Overdue label Mar 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2023
@Julesssss
Copy link
Contributor Author

Same as above. We talked about this in slack and will likely target 8.0

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2023
@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@Julesssss
Copy link
Contributor Author

No rush here

@melvin-bot melvin-bot bot removed the Overdue label Jun 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@Julesssss
Copy link
Contributor Author

Same as above

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@Julesssss
Copy link
Contributor Author

Okay, so Android 7.0 still seems like a reasonable minimum supported version:

Screenshot 2023-07-19 at 16 51 28 Screenshot 2023-07-19 at 16 49 44

@Julesssss
Copy link
Contributor Author

I'm just not sure we have a true problem here yet...

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@Julesssss
Copy link
Contributor Author

No change

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@Julesssss
Copy link
Contributor Author

Discussed in Slack, no real deadline here though.

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@shubham1206agra
Copy link
Contributor

@Julesssss #28914 will make the minimum SDK version to v26, i.e., Android 8.0. Can you check the same?

@Julesssss
Copy link
Contributor Author

Thank you, I commented on the PR.

@shubham1206agra
Copy link
Contributor

Update: RN 0.73 may make minimum sdk version to 23.
Since facebook/react-native#39671 just got into 0.73.0-rc.5

@Julesssss
Copy link
Contributor Author

Thanks, Android 7.0 (SDK 23) seems reasonable 👍

@Julesssss
Copy link
Contributor Author

No recent updates

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@Julesssss
Copy link
Contributor Author

We have discussing SDK 23 as a reasonable minimum here

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@mrousavy
Copy link
Contributor

mrousavy commented Feb 1, 2024

I'd say 23 is definitely reasonable.

@melvin-bot melvin-bot bot added the Overdue label Feb 22, 2024
@Julesssss
Copy link
Contributor Author

No current need to bump the min version.

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@mrousavy
Copy link
Contributor

Yup, VisionCamera V4 will work on minSdk 21

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@Julesssss
Copy link
Contributor Author

No need for this bump yet

@melvin-bot melvin-bot bot removed the Overdue label Apr 5, 2024
@Julesssss
Copy link
Contributor Author

Closing, we'll create a new issue for discussion when we actually need to make a bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Julesssss @mrousavy @shubham1206agra @Santhosh-Sellavel