-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add spinning loader until full list of policies is successfully download on the client #54238
base: main
Are you sure you want to change the base?
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@twilight2294 Can you please raise the Eslint warnings on Slack and see how can we solve it? What should be used as default for these? |
@twilight2294 Can you please merge main? |
sure, i will also update the videos today, had problem with my machine for past 2 days |
Don't forget to ask this. whether it should be CONST.DEFAULT_NUMBER_ID or something else? I am not sure about this too... |
Add QA steps and tests. |
@twilight2294 Please merge main again. There are issues on ios Build. |
@twilight2294 Could you please update the vids, test steps, and merge main? I also noticed that your signed commits do not show the username (Something to check). |
So strange, I will take a look at this, thanks for checking |
Signed-off-by: GitHub <noreply@github.com>
Sorry @parasharrajat I am yet to be added to the slack, I have filled the google form but the invites are not available currently . I read the docs attached with the error and tried fixing the errors, I updated everything according to the docs: |
@parasharrajat updated the videos and added testing steps, can you please review this again, thanks a lot |
@@ -1,5 +1,5 @@ | |||
type LeavePolicyParams = { | |||
policyID: string; | |||
policyID?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not change the type.
src/libs/ReportUtils.ts
Outdated
@@ -7381,7 +7381,7 @@ function getWorkspaceChats(policyID: string, accountIDs: number[], reports: Onyx | |||
* | |||
* @param policyID - the workspace ID to get all associated reports | |||
*/ | |||
function getAllWorkspaceReports(policyID: string): Array<OnyxEntry<Report>> { | |||
function getAllWorkspaceReports(policyID: string | undefined): Array<OnyxEntry<Report>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this.
src/libs/actions/Policy/Policy.ts
Outdated
@@ -725,7 +725,7 @@ function clearWorkspaceReimbursementErrors(policyID: string) { | |||
Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errorFields: {reimbursementChoice: null}}); | |||
} | |||
|
|||
function leaveWorkspace(policyID: string) { | |||
function leaveWorkspace(policyID: string | undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's early return here when policyid is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
@twilight2294 Can you please fix the conflicts and make the requested changes? |
Signed-off-by: GitHub <noreply@github.com>
@parasharrajat can you please review again |
Screenshots🔲 iOS / native24.12.2024_16.32.52_REC.mp4🔲 iOS / Safari20.12.2024_18.33.43_REC.mp4🔲 MacOS / Desktop20.12.2024_18.03.16_REC.mp4🔲 MacOS / Chrome20.12.2024_17.59.21_REC.mp4🔲 Android / Chrome20.12.2024_18.29.59_REC.mp4🔲 Android / native21.12.2024_01.39.37_REC.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issues
section above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Tests
section - I verified the steps for Staging and/or Production testing are in the
QA steps
section - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReport
and notonIconClick
). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />
. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*
files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copy
label for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md
) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar
, I verified the components usingAvatar
have been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor) - Any internal methods bound to
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avatar
is modified, I verified thatAvatar
is working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Design
label so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollView
component to make it scrollable when more elements are added to the page. - If the
main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
Explanation of Change
Fixed Issues
$ #52766
PROPOSAL: #52766 (comment)
Tests
Test 1:
Precondition: Be on 3G / Slow internet
Verify that: you will see a loading spinner before seeing the workspace list page / empty workspace screen
Test 2:
Precondition: Be on 3G / Slow internet
Verify that: you will see a loading spinner before seeing the workspace list page / create workspace screen
Offline tests
Test 1:
Verify that: you will not see a loading spinner before seeing the workspace list page / empty workspace screen
Test 2:
Precondition: Be on 3G / Slow internet
Verify that: you will not see a loading spinner before seeing the workspace list page / create workspace screen
QA Steps
Test 1:
Precondition: Be on 3G / Slow internet
(Note that this will not be reproducible on fast internet)
Verify that: you will see a loading spinner before seeing the workspace list page / empty workspace screen
Test 2:
Precondition: Be on 3G / Slow internet
Verify that: you will see a loading spinner before seeing the workspace list page / create workspace screen
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen_recording_20241223_122217.mp4
Android: mWeb Chrome
Screen_recording_20241223_122534.mp4
iOS: Native
Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-23.at.12.14.39.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-23.at.12.16.37.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-12-23.at.12.00.53.PM.mov
MacOS: Desktop
Screen.Recording.2024-12-23.at.12.04.03.PM.mov