ospfd: OSPF multi-instance default origination fixes #17436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Nov 16, 2024
|
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
When originating a default AS-External LSA in one OSPF instance, it wasn't working if the criteria route was installed by another OSPF instance. This required more flexible processing of the OSPF external route information. Also fix problem multi-instance display for "show ip ospf <instance> database ...". Signed-off-by: Acee Lindem <acee@lindem.com>
aceelindem
force-pushed
the
aceelindem/ospf-multi-instance-default
branch
from
382b7a6
to
6afd56d
Compare
Note I've got a topotest that I'm going to add to this PR under a separate "tests" commit. |
This change adds a topotest to test various case of OSPF multi-instance origination including cases where the criteria route is from another instance of OSPF, as well as the same OSPF instance (where a default should not be originated). Signed-off-by: Acee Lindem <acee@lindem.com>
Pushed separate commit to PR with a topotest. |
|
CI:rerun |
4 similar comments
|
CI:rerun |
|
CI:rerun |
|
CI:rerun |
|
CI:rerun |
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When originating a default AS-External LSA in one OSPF instance, it wasn't working if the criteria route was installed by another OSPF instance. This required more flexible processing of the OSPF external route information.