Mechanic talent "Residual Waste" and "Mass Production" should check a generic tag to prevent item duplication

[A2ur3]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

EK crate items
for example Crate of Plastic
fabrication recipe = 10 plastic -> can be triggered by Mass Production
deconstruction outputs = 10 plastic -> can be triggered by Residual Waste unless you add one of these tags to this item "geneticmaterial,unidentifiedgeneticmaterial,circuitboxcomponent,lightcomponent"

Reproduction steps

1. subscribe and enable EK Utilities Remastered
2. make a character who has talents in question fabricate and deconstruct Crate of Plastic
3. item duplication

Bug prevalence

Just once

Single player or multiplayer?

Single player

-

No response

Version

v1.6.19.1 (Unto the Breach Update Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Ek-Videogames]

Honestly, if the devs ever felt like taking the initiative to try and fix & re-implement recycling into the game again. They could have some kind of skill and/or talent based mechanic for increasing the amount of items yielded from recycling, as opposed to the sort of hacky half-measured implementation of spawning generic scrap.

For example: Having deconstruction results defined in-XML with some kind of 'minimum' and 'maximum' values.
(or like how 'deconstructionCondition' already works)

Example

<Deconstruct time="20">
  <Item identifier="aluminium" amount="1" maxamount="4"/>
  <Item identifier="copper" amount="1" maxamount="2"/>
  <Item identifier="tin" amount="0" maxamount="2"/>
  <Item identifier="plastic" amount="0" maxamount="1"/>
</Deconstruct>

Could be done several ways, like requiring talent, or some skill level.

[Regalis11]

Addressed in https://github.com/FakeFishGames/Barotrauma-development/commit/a09af1e4b432780a3d32ea9bd158fd1e85325ee6

Made "residual waste" and "mass production" talents a bit more modder-friendly. The former had a chance of duplicating deconstruction output and the latter a chance of not consuming some of the fabrication ingredients. It was hard to exclude items from those talents though: addressed that by making them ignore items with the tags "disallowduplicatedeconstructoutput" and "disallowremovefabricationingredient" respectively. #15246

The change unfortunately didn't make it in time for the upcoming update, but will be included in the one after that.