Undo the hardcoding of the outpost deathmatch mission #15417
profole
started this conversation in
Unstable feedback
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In current stable the xml for the outpost deathmatch mission is
Which was changed to the following one in unstable
Notably, the
<TriggerEvent state="0" delay="10" eventtag="deathmatchweapondrop" />
line was removed and its most likely hardcoded into the mission/chosen map now.I assume this is done to get around making xml stuff to check which map is being played (since the old one couldnt do that without making a new missiontype and we now need that since ruin map needs to spawn different things), but this just cant be it.
My mod "Better Outpost Deathmatch Framework" for example, used the old system to add a new custom event triggered by a custom missiontype to allow people to still play PvP vanilla while having my mod enabled.
Considering that the goal is to de-hardcode more stuff for xml modding, this shouldnt be done.
I suggest adding a new xml attribute for TriggerEvent to check against the selected map (something like "OutpostTag" or "MapTag") instead.
Beta Was this translation helpful? Give feedback.
All reactions