Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding support for the TCP framing method used by the 1.0 OSC spec #17

Open
ChrisAshworth opened this issue Dec 20, 2016 · 4 comments

Comments

@ChrisAshworth
Copy link
Member

In the comments of #3, @richardwilliamson notes:

The default setting on Eos for OSC is version 1.0 - which means that the settings have to be changed to communicate over TCP with an eos console, it would be useful if there was an option on the OSCClient to use OSC version 1.0 packets.

The OSC 1.0 spec recommended using a size-count-preamble to send OSC messages over TCP.

It might be nice to allow specifying this as an option.

@richardwilliamson
Copy link
Contributor

I think I've made this work - although I don't seem to be able to do a pull request (see https://github.com/richardwilliamson/F53OSC-RW for my working version - changes are in F53OSCClient, F53OSCParser and F53OSCSocket)

I did a couple of other tweaks as well

@ChrisAshworth
Copy link
Member Author

Cool! Hm, having a pull request for comparison helps a lot to hone in on the specific changes.

Does this page help set one up?

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

@richardwilliamson
Copy link
Contributor

think that's done - I took most of the code from the old commit before 1.0 support was dropped, however for some reason that used 64 bit integers for the size, where they seem to need to be 32 bit, so I changed that.

It seems to work fine for me when talking to an eos, I haven't done a great deal of testing though

balord added a commit that referenced this issue Feb 12, 2020
@ChrisAshworth
Copy link
Member Author

@balord created branch 17-tcp-osc-1.0-framing for handling TCP non-SLIP framing (OSC 1.0).

Full disclosure — that branch is untested and might not be something we decide to merge. It should be considered experimental for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants