Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB Errors are not rolled back #209

Open
Fluxticks opened this issue Feb 2, 2022 · 0 comments · May be fixed by #227
Open

DB Errors are not rolled back #209

Fluxticks opened this issue Feb 2, 2022 · 0 comments · May be fixed by #227
Labels
bug Something isn't working

Comments

@Fluxticks
Copy link
Collaborator

When an error occurs with the DB, the exception handler should perform rollback any attempted changes.

The fix:

  • Add session.rollback() to every DB exception handler
@Fluxticks Fluxticks added the bug Something isn't working label Feb 2, 2022
@Fluxticks Fluxticks linked a pull request Feb 13, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added rollback to when there are db errors FragSoc/esports-bot
1 participant
@Fluxticks