Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting/error checking to CI #85

Open
Laura7089 opened this issue Jun 1, 2021 · 3 comments
Open

Add linting/error checking to CI #85

Laura7089 opened this issue Jun 1, 2021 · 3 comments
Labels
continuous integration Relates to the CI system enhancement New feature or request

Comments

@Laura7089
Copy link
Member

Right now, the CI only builds the docker image and pushes it if the build succeeds.

We could link in tools like MyPy, flake8, pyflakes, mccabeand memestra for informing us about issues with styling, logic, errors etc. Using that information, we can also automatically block merges until issues are fixed.
@Laura7089 Laura7089 added the enhancement New feature or request label Jun 1, 2021
@Laura7089
Copy link
Member Author

Sort-of blocked by #74

@Laura7089 Laura7089 mentioned this issue Jun 1, 2021
Open
@Laura7089
Copy link
Member Author

See #168 for mypy typing progress

@Laura7089
Copy link
Member Author

See #169 for flake8/PEP8 progress

@Laura7089 Laura7089 added the continuous integration Relates to the CI system label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous integration Relates to the CI system enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Laura7089