Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[defect]: dictionary man page does not list all options #5346

Open
johnthacker opened this issue Jun 21, 2024 · 5 comments
Open

[defect]: dictionary man page does not list all options #5346

johnthacker opened this issue Jun 21, 2024 · 5 comments
Labels
defect category: a defect or misbehaviour

Comments

@johnthacker
Copy link

What type of defect/bug is this?

Unexpected behaviour (obvious or verified by project member)

How can the issue be reproduced?

  1. Read the man page, whether online or as distributed.
  2. Compare it to the options present in the distributed dictionary, and parsed by the dictionary parser.

Log output from the FreeRADIUS daemon

New options like `secret`, `array`, `concat` and others are all not documented.

Relevant log output from client utilities

No response

Backtrace from LLDB or GDB

No response

@johnthacker johnthacker added the defect category: a defect or misbehaviour label Jun 21, 2024
@alandekok
Copy link
Member

Only v4 supports secret, array, etc. We're moving away from man pages for much of v4, and moving to Antora, which is at https://freeradius.org/documentation/freeradius-server/4.0.0/reference/dictionary/attribute.html

@johnthacker
Copy link
Author

array (and concat) are present in some of the dictionary files on v3.2.x though. (secret is only in the internal dictionary in v3.2) Is it that the case that array can be present and the parser simply ignores it in v3.2?

@alandekok
Copy link
Member

array is only used for DHCP. And concat is only used for EAP-Message.

We're happy to take patches to fix the documentation, but it is definitely not a priority for us to do that work. The use-case where people need to know about those flags are vanishingly rare.

We're concentrating on getting v4 out the door, with full documentation.

@johnthacker
Copy link
Author

Sure, no problem. I do think concat is used for a few others - EAPoL-Announcement, PKM-SS-Cert, PKM-CA-Cert, but in Wireshark at least only EAP-Message is actually reassembled.

Just trying to work on updating the parsing of the format within Wireshark so we can update to at least the 3.2.x dictionaries, offer any patches for a handful of missing attributes in the FreeRADIUS versions, and properly include the copyright and license lines that have been added to some of the files since the last time they were synced.

@alandekok
Copy link
Member

That's helpful, thanks

I'll try to find time to update the man pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect category: a defect or misbehaviour
Projects
None yet
Development

No branches or pull requests

2 participants