You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, since bytes is aligned to 1 byte, misaligned pointer will be passed to from_raw_parts, which is similar to the issue here: #538 (comment)
Second, since the code is trying to casting a pointer of Vec to the pointer of inner type where the Vec has unstable layout.
In the comments, we found the explanation that BinaryBlob has less type safety and it accepts any type T that is Copy, and it lacks the type_id system. Is this method designed for purpose?
The text was updated successfully, but these errors were encountered:
Hi, we consider that the usage of
Vec::from_raw_parts()
here is unsoundFyrox/fyrox-core/src/visitor.rs
Lines 554 to 559 in 4724d98
First, since
bytes
is aligned to 1 byte, misaligned pointer will be passed tofrom_raw_parts
, which is similar to the issue here: #538 (comment)Second, since the code is trying to casting a pointer of
Vec
to the pointer of inner type where theVec
has unstable layout.In the comments, we found the explanation that
BinaryBlob has less type safety
andit accepts any type T that is Copy, and it lacks the type_id system
. Is this method designed for purpose?The text was updated successfully, but these errors were encountered: