Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probability of precipitation to timeseries graph? #201

Open
jpolton opened this issue Mar 26, 2023 · 9 comments
Open

Add probability of precipitation to timeseries graph? #201

jpolton opened this issue Mar 26, 2023 · 9 comments

Comments

@jpolton
Copy link

jpolton commented Mar 26, 2023

Probability of precipitation is downloaded with the 3hrly forecast data. And is quite interesting.
This can be overlayed on the precipitation rate graph with a separate y-axis (on e.g. RHS of rainfall graph).
On a 7.5" screen this fits fine with a little bit of nudging of the other elements in the DisplayForecastSection().

IMG_9623
IMG_9624

Would this be of interest as a Pull Request?

@dreamy1
Copy link

dreamy1 commented Mar 27, 2023

Yes :-)

@jpolton
Copy link
Author

jpolton commented Mar 28, 2023

Started a PR: #202.
Implemented in Waveshare_7_5_T7.ino only, for now.

@jpolton
Copy link
Author

jpolton commented Apr 6, 2023

Edits should work on other screens but the forecast graph spacing might have to be tweaked to get the extra y-axis labels to fit.

For the 7.5" 800x480 screen this was a simple edit in the DisplayForecastSection() method (~line 407):

int gx = (SCREEN_WIDTH - gwidth * 4) / 5 + 5;

-->

int gx = (SCREEN_WIDTH - gwidth * 4) / 5 + 1;

I am reluctant to make a PR for things I can't personally test, unless someone else wants the PR and can help with that.

@jpolton
Copy link
Author

jpolton commented May 6, 2023

Yes :-)

@dreamy1 @Kobbe1 Let me know what board you have, I'll make the changes for it and you could see if it looks OK?

@dreamy1
Copy link

dreamy1 commented May 6, 2023

Thanks a lot - i have the 7.5" and the Liliygo T5 4.7" screen...but at the moment, unfortunately no time for testing...

@Kobbe1
Copy link

Kobbe1 commented May 6, 2023

I have a 4.2 inch board. I did not want to wait so already more or less implemented in my local copy which is heavily customized.
I really love this feature - been using it since a few weeks now, thanks for the awesome idea.
I did not actually add an Y-axis to show the % - as it is always 0 - 100% I don't think it is really needed and things are tight on a 4.2 screen.

I might be able to test it some time in the future when I merge other new changes but I don't regularly update it if all is well as it is "in production" - with the family, so changes are risky :)

@G6EJD
Copy link
Owner

G6EJD commented May 6, 2023

I agree, actually OWM’s predicted rainfall amounts to gives a profile of predicted precipitation without the need to draw it as yet another graph line.

@jpolton
Copy link
Author

jpolton commented May 8, 2023

I agree, actually OWM’s predicted rainfall amounts to gives a profile of predicted precipitation without the need to draw it as yet another graph line.

Yes but overlaying "probability of rainfall" as a line on top of rainfall rate is illuminating, especially when the probability is low. Together they make an estimate of risk of getting wet during e.g. the commute, laundry outside.
IMG_0121

For smaller screens temperature and humidity could also be combined (where humidity is otherwise not plotted), though some method of distinguishing the lines (colour, thickness, style) would have to be experimented with.

@jpolton
Copy link
Author

jpolton commented Nov 10, 2023

Associated PR #202 got closed when I attempted to move it off my master branch. Created a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants