Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Check that the geos installation produces a usable library and runtime #3313

Open
Algiane opened this issue Aug 29, 2024 · 1 comment
Open

ci: Check that the geos installation produces a usable library and runtime #3313

Algiane opened this issue Aug 29, 2024 · 1 comment
Labels
type: build system Build system issue type: CI Concerns github workflows or generic CI type: feature New feature or request type: new A new issue has been created and requires attention type: testing Unit tests, non-regression testing, ...

Comments

@Algiane
Copy link
Contributor

Algiane commented Aug 29, 2024 •
edited
Loading

What is the requested feature?
The integration of the PR #3282 has broken the non-regression tests of Pangea3 (see issue #3305) due to a missing installation of shared libraries (see fix #3307).

It is a blind spot in the current ci: it should be tested somewhere that we can successfully use the ci installation.

Describe the solution you'd like
One or few very fast tests have to execute the geos runtime produced in the install directory (and maybe after removing the build directory).
@Algiane Algiane added type: feature New feature or request type: testing Unit tests, non-regression testing, ... type: build system Build system issue type: new A new issue has been created and requires attention type: CI Concerns github workflows or generic CI labels Aug 29, 2024
@Algiane Algiane mentioned this issue Aug 29, 2024
Merged
@rrsettgast
Copy link
Member

rrsettgast commented Aug 30, 2024 •
edited
Loading

@cssherman @CusiniM I think the solution here is to have the integrated tests CI run executed from the install directory. This way we pretty much are assured that everything is installed correctly. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: build system Build system issue type: CI Concerns github workflows or generic CI type: feature New feature or request type: new A new issue has been created and requires attention type: testing Unit tests, non-regression testing, ...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrsettgast @Algiane